Yes, if you do it only when you could locate gEdkiiPlatformLogoProtocolGuid.
This way you don’t need a PCD and the build option is only used for logo module
built-in or not.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87423):
Do you mean check if the protocol exist in PlatformBootManager.c? i.e.
if (gEdkiiPlatformLogoProtocolGuid ) {
gST->ConOut->ClearScreen (gST->ConOut);
If not, can I ask the reasoning, as if I understand it, that would be a complex
solution for saving one PCD
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
s.io
Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot
Splash
Happy to fix the patch, just to check, with the build option? It does sound
like a safer bet - even if we default it to true.
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages
Happy to fix the patch, just to check, with the build option? It does sound
like a safer bet - even if we default it to true.
Thanks
Sean
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87365):
, Maurice ; You,
Benjamin
Subject: RE: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot
Splash
Can you avoid introducing the PCD by always including BootLogo driver?
By the way, you changed brotli version. Is that expected?
-Original Message-
From: devel@edk2.groups.io
; Ma, Maurice ; You, Benjamin
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash
Provide a build option to use a Boot Splash logo.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Library/BrotliCustomDecompressLib
, Sean ; Ni,
Ray ; Ma, Maurice ; You, Benjamin
Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Provide option to use Boot Splash
Provide a build option to use a Boot Splash logo.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Library
Provide a build option to use a Boot Splash logo.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Signed-off-by: Sean Rhodes
---
MdeModulePkg/Library/BrotliCustomDecompressLib/brotli | 2 +-
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 5 +
Provide a build option to use a Boot Splash logo.
Signed-off-by: Sean Rhodes
---
.../Library/PlatformBootManagerLib/PlatformBootManager.c | 5 +
.../PlatformBootManagerLib/PlatformBootManagerLib.inf| 2 ++
UefiPayloadPkg/UefiPayloadPkg.dec| 3 +++
