Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-16 Thread Ard Biesheuvel
On Tue, 16 Jan 2024 at 10:37, Laszlo Ersek wrote: > > On 1/15/24 18:56, Ard Biesheuvel wrote: > > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > >> > >> On 1/12/24 12:37, Gerd Hoffmann wrote: > >>> This is a little series containing the flash corruption fix sent > >>> yesterday with an

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-16 Thread Laszlo Ersek
On 1/15/24 18:56, Ard Biesheuvel wrote: > On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: >> >> On 1/12/24 12:37, Gerd Hoffmann wrote: >>> This is a little series containing the flash corruption fix sent >>> yesterday with an slightly improved commit message and some small >>> improvements on

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Ard Biesheuvel
On Mon, 15 Jan 2024 at 11:21, Laszlo Ersek wrote: > > On 1/12/24 12:37, Gerd Hoffmann wrote: > > This is a little series containing the flash corruption fix sent > > yesterday with an slightly improved commit message and some small > > improvements on top of this. > > > > Gerd Hoffmann (4): > >

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Laszlo Ersek
On 1/15/24 11:21, Laszlo Ersek wrote: > - please only ever apply the bit-neg operator on values that are UINT32, > UINTN, or UINT64. Otherwise we get sign bit flipping, and that's > terrible. (Most people are not even aware of it happening.) Doing this is BTW not as obvious as it might seem,

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-15 Thread Laszlo Ersek
On 1/12/24 12:37, Gerd Hoffmann wrote: > This is a little series containing the flash corruption fix sent > yesterday with an slightly improved commit message and some small > improvements on top of this. > > Gerd Hoffmann (4): > OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads >

[edk2-devel] [PATCH 0/4] OvmfPkg/VirtNorFlashDxe: fix corruption + misc small improvements

2024-01-12 Thread Gerd Hoffmann
This is a little series containing the flash corruption fix sent yesterday with an slightly improved commit message and some small improvements on top of this. Gerd Hoffmann (4): OvmfPkg/VirtNorFlashDxe: fix shadowbuffer reads OvmfPkg/VirtNorFlashDxe: clarify block write logic