Re: [edk2-devel] [PATCH 09/10] OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code

2019-04-15 Thread Philippe Mathieu-Daudé
On 4/13/19 1:31 AM, Laszlo Ersek wrote: > RH covscan justifiedly reports a path through InstallXenTables() where > DsdtTable can technically remain NULL. > > If this occurs in practice, then the guest and the VMM are out of sync on > the interface contract. Catch the situation with a code snippet

[edk2-devel] [PATCH 09/10] OvmfPkg/AcpiPlatformDxe: catch theoretical nullptr deref in Xen code

2019-04-12 Thread Laszlo Ersek
RH covscan justifiedly reports a path through InstallXenTables() where DsdtTable can technically remain NULL. If this occurs in practice, then the guest and the VMM are out of sync on the interface contract. Catch the situation with a code snippet that halts in RELEASE builds, and in DEBUG builds