Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-17 Thread Tinh Nguyen via groups.io
Thank you for your feedback; I will submit v2 as soon as possible. Regards, Tinh On 3/15/2023 12:59 AM, Rebecca Cran wrote: On 3/14/23 6:48 AM, Leif Lindholm wrote: No objection to that. But can we do it like this?: Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call   

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-17 Thread Tinh Nguyen via groups.io
I sorry for not seeing your and Leif's emails, so I added you again. - Tinh On 3/16/2023 8:00 PM, Rebecca Cran wrote: Given Leif's comments, I was expecting a new version with some changes. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onl

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-17 Thread Tinh Nguyen via groups.io
I sorry for not seeing your and Leif's emails, so I added you again. - Tinh On 3/16/2023 8:00 PM, Rebecca Cran wrote: Given Leif's comments, I was expecting a new version with some changes. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onl

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-16 Thread Rebecca Cran
Given Leif's comments, I was expecting a new version with some changes. -- Rebecca Cran On 3/16/23 2:30 AM, Tinh Nguyen via groups.io wrote: + Rebecca Could you kindly help me in reviewing this patch? Thanks, - Tinh On 13/03/2023 13:43, Tinh Nguyen wrote: The BIOS Firmware Version in th

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-16 Thread Tinh Nguyen via groups.io
+ Rebecca Could you kindly help me in reviewing this patch? Thanks, - Tinh On 13/03/2023 13:43, Tinh Nguyen wrote: The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from the fixed PcdFirmwareVersionString or platform specific OemMiscLib. In fact, the support from OemMiscLib comes

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-14 Thread Rebecca Cran
On 3/14/23 6:48 AM, Leif Lindholm wrote: No objection to that. But can we do it like this?: Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call SetBiosVersion (); and move the selection logic fully into SetBiosVersion? Rebecca, thoughts? Arguably, once an OemMiscLib d

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-14 Thread Leif Lindholm
Hi Tinh, +Rebecca On Mon, Mar 13, 2023 at 23:52:41 +0700, Tinh Nguyen via groups.io wrote: > On 3/13/2023 10:03 PM, Leif Lindholm wrote: > > On Mon, Mar 13, 2023 at 13:43:21 +0700, Tinh Nguyen wrote: > > > The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from > > > the fixed PcdFirmwa

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-13 Thread Tinh Nguyen via groups.io
Hi Leif, My comments is in below On 3/13/2023 10:03 PM, Leif Lindholm wrote: On Mon, Mar 13, 2023 at 13:43:21 +0700, Tinh Nguyen wrote: The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from the fixed PcdFirmwareVersionString or platform specific OemMiscLib. In fact, the support fr

Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-13 Thread Leif Lindholm
On Mon, Mar 13, 2023 at 13:43:21 +0700, Tinh Nguyen wrote: > The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from > the fixed PcdFirmwareVersionString or platform specific OemMiscLib. > In fact, the support from OemMiscLib comes into play when the firmware > version may be modified at

[edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-12 Thread Tinh Nguyen via groups.io
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from the fixed PcdFirmwareVersionString or platform specific OemMiscLib. In fact, the support from OemMiscLib comes into play when the firmware version may be modified at boot time for extended information. Therefore, the priority of ge