Sounds good, thank you.
Reviewed-by: Yi Li
-Original Message-
From: Hou, Wenxing
Sent: Monday, January 8, 2024 4:23 PM
To: Li, Yi1 ; devel@edk2.groups.io
Cc: Yao, Jiewen ; Jiang, Guomin
Subject: RE: [PATCH 1/1] CryptoPkg: fix gcc build fail for CryptoPkgMbedtls
Hi,
For VS build,
Hi,
For VS build, the size is same for enable or disable MBEDTLS_NO_UDBL_DIVISION,
because the previous code only had GCC build failure. This MACRO doesn't affect
the VS build.
For GCC build, the previous code didn`t have the size because of the build
failure.
To compare the size ,I add the
Hi,
> disabling it can reduce code size in some embedded targets.
Could you provide size change after/before this define enabled?
Thanks,
Yi
-Original Message-
From: Hou, Wenxing
Sent: Thursday, January 4, 2024 4:34 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Li, Yi1 ; Jiang,
Guomin
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4630
Enable MBEDTLS_NO_UDBL_DIVISION to fix GCC x64 build failure.
Cc: Jiewen Yao
Cc: Yi Li
Cc: Guomin Jiang
Signed-off-by: Wenxing Hou
---
CryptoPkg/Library/MbedTlsLib/Include/mbedtls/mbedtls_config.h | 2 +-
1 file changed, 1
