Hello,
I've done some investigation into the password issue and I think I have the
proposition on how to solve it. The issue arises due to the driver checking the
PxIS.TFES(task file error status) and if TFES is set it performs recovery
steps(this is correct according to AHCI spec 6.2.2) and re
; Albecki, Mateusz
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Ata: Fix command status
reporting
Thanks.
For the patch:
Reviewed-by: Hao A Wu mailto:hao.a...@intel.com>>
Will merge the patch early next week.
For the open with regard to:
https://github.com/tianocore/edk2/blob/
@edk2.groups.io On Behalf Of Albecki, Mateusz
Sent: Thursday, December 8, 2022 12:25 AM
To: Albecki; Albecki, Mateusz ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Ata: Fix command status
reporting
Hello,
Really sorry for missing the mails. Seems like my mail was
Hello,
Really sorry for missing the mails. Seems like my mail was misconfigured and I
didn't get the messages(had to check the group site).
"I cannot remember why EFI_SUCCESS is eventually returned for the above error
case. Could you help to remind me of the details? Thanks."
To answer this -
] MdeModulePkg/Ata: Fix command status
reporting
Below patch didn't resolve https://bugzilla.tianocore.org/show_bug.cgi?id=4011
since AhciRecoverPortError return success on incorrect drive password and
continues with additional retries before returning to caller.
From: Wu, Hao A mailto:
Below patch didn't resolve https://bugzilla.tianocore.org/show_bug.cgi?id=4011
since AhciRecoverPortError return success on incorrect drive password and
continues with additional retries before returning to caller.
From: Wu, Hao A
Sent: Tuesday, October 18, 2022 8:37 PM
To: Anbazhagan, Baraneed
ds,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao A
> Sent: Wednesday, October 19, 2022 9:37 AM
> To: Anbazhagan, Baraneedharan ; Albecki, Mateusz
> ; devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/Ata:
Hello Baraneedharan Anbazhagan,
Could you help to check if this patch can resolve the issue
https://bugzilla.tianocore.org/show_bug.cgi?id=4011 when switching back to:
"#define AHCI_COMMAND_RETRIES 5"?
This change can be accessed for integration at:
https://github.com/tianocore/edk2/commit/f2e
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4016
AtaAtapiPassThru driver was reporting recovery status on failed command
packets which led to incorrect flows in upper layers and to SCT tests
fails. This commit will change the logic to report command status.
Cc: Hao A Wu
Cc: Ray Ni
