Re: [edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

2022-07-07 Thread Saloni Kasbekar
Hi Maciej, 1. I will update the code to add a new function to split that code into a separate function. Once the basic auth patch is checked in, I’ll re-send the changes for review so that we have the complete logic in the new function. 2. I see your point. I’ll update the code to fix

Re: [edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

2022-07-01 Thread Maciej Rabeda
Hi Saloni, This patch contains several problems. At minimum: 1. HttpBootLoadFile() logic around calling HttpBootGetBootFile() is becoming more complex - and BZ 2504 patch adds to it. I am becoming convinced that this part of HttpBootLoadFile() should have a separate function with a

[edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

2022-06-22 Thread Saloni Kasbekar
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add CONNECT HTTP command in order to create a tunnel from HTTPS Proxy Server to EndPoint Server. Add support to connect through proxy server using DevicePath sent to the Boot Manager. Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Cc: