Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-05-03 Thread Rebecca Cran
On 5/3/23 01:43, Corvin Köhne wrote: thanks for checking. Type 4 is the local ACPI NMI entry. See https://github.com/freebsd/freebsd-src/blob/1d7355248b5cf3b0d09247c6c7c4ff2d40c39945/usr.sbin/bhyve/acpi.c#L627-L636 It's described in ACPI spec 6.5 chapter 5.2.12.7. Thanks! I'll send a patch to

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-05-03 Thread Corvin Köhne
On Tue, 2023-05-02 at 20:25 -0600, Rebecca Cran wrote: > I applied the patch and tested it. The UEFI Shell command "acpiview" > reports an error. I enabled the "acpiview" command with the patch: > > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index d0d2712c5662..0c04

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-05-02 Thread Rebecca Cran
I applied the patch and tested it. The UEFI Shell command "acpiview" reports an error. I enabled the "acpiview" command with the patch: diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc index d0d2712c5662..0c04e4834cf7 100644 --- a/OvmfPkg/Bhyve/BhyveX64.dsc +++ b/OvmfPkg/Bhy

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-04-17 Thread Corvin Köhne
On Mon, 2023-04-17 at 14:14 +0200, Gerd Hoffmann wrote: > On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote: > > It's much easier to create configuration dependend ACPI tables for > > bhyve > > than for OVMF. For this reason, don't use the statically created > > ACPI > > tables provided

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-04-17 Thread Gerd Hoffmann
> Hi Gerd, > > thanks for your reply. It's mostly the same code. Only the start and > end of the scanned range differ. So, it does make sense to share the > same implementation. > Where's the right place for this shared implementation? Is it > "OvmfPkg/Library"? Yes. take care, Gerd -=-=-=-

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-04-17 Thread Gerd Hoffmann
On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote: > It's much easier to create configuration dependend ACPI tables for bhyve > than for OVMF. For this reason, don't use the statically created ACPI > tables provided by OVMF. Instead prefer the dynamically created ACPI > tables of bhyve.

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables

2023-04-17 Thread Rebecca Cran
On 4/17/23 5:46 AM, Corvin Köhne wrote: + +/** + Get the address of bhyve's ACPI Root System Description Pointer (RSDP). + + @param RsdpPtr Return pointer to RSDP. + + @return EFI_SUCCESS Bhyve's RSDP successfully found. + @return EFI_NOT_FOUND Couldn't find bhyve's