Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

2023-08-29 Thread Gao, Zhichao
Already add me push tag. Once it pass the CI, it would be merged. Thanks, Zhichao > -Original Message- > From: Nhi Pham > Sent: Tuesday, August 29, 2023 10:36 AM > To: Gao, Zhichao ; Nhi Pham > ; devel@edk2.groups.io > Subject: Re: [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe

Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

2023-08-28 Thread Nhi Pham via groups.io
Thanks Zhichao, I updated the commit message and also created a PR at https://github.com/tianocore/edk2/pull/4767 Please help check. Regards, -Nhi On 8/21/2023 2:01 PM, Gao, Zhichao wrote: Better to update the commit message with specific SMBIOS version. Others looks good to me. Thanks, Zhi

Re: [edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

2023-08-21 Thread Gao, Zhichao
Better to update the commit message with specific SMBIOS version. Others looks good to me. Thanks, Zhichao > -Original Message- > From: Nhi Pham > Sent: Friday, August 18, 2023 2:54 PM > To: devel@edk2.groups.io > Cc: Nhi Pham ; Gao, Zhichao > > Subject: [PATCH 1/1] ShellPkg/SmbiosView:

[edk2-devel] [PATCH 1/1] ShellPkg/SmbiosView: Update display of PCIe system slot ID

2023-08-17 Thread Nhi Pham via groups.io
This updates the system slot ID up to SlotTypePCIExpressGen6andBeyond (0xC4) to cover modern PCIe Gen. Cc: Zhichao Gao Signed-off-by: Nhi Pham --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Libr