Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-10 Thread Jeshua Smith via groups.io
Thanks for the review. Reply inline. -Original Message- From: Pierre Gondois Sent: Tuesday, October 10, 2023 4:14 AM To: Jeshua Smith ; devel@edk2.groups.io Cc: sami.muja...@arm.com Subject: Re: [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling External email:

Re: [edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-10 Thread PierreGondois
Hello Jeshua, Just a small remark, but this should be equivalent, so: Reviewed-by: Pierre Gondois On 10/6/23 18:28, Jeshua Smith wrote: This fixes two bugs and adds some enhancements to the handling of characters and strings in objects being printed by the CM ObjectParser. Bug fixes: 1. Print

[edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-06 Thread Jeshua Smith via groups.io
This fixes two bugs and adds some enhancements to the handling of characters and strings in objects being printed by the CM ObjectParser. Bug fixes: 1. PrintOemID() currently attempts to print characters with "%C", but the correct syntax is (lowercase) "%c". This bug results in "CC" bein