Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-23 Thread Wu, Hao A
dea on why the proposed change can resolve the issue. Best Regards, Hao Wu From: Sean Rhodes Sent: Friday, September 23, 2022 4:02 PM To: Wu, Hao A Cc: devel@edk2.groups.io; Ni, Ray Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path Hi Hao I retes

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-23 Thread Sean Rhodes
; > Could you help to double check if the change is really what you want to do? > > > > Best Regards, > > Hao Wu > > > > *From:* devel@edk2.groups.io * On Behalf Of *Sean > Rhodes > *Sent:* Wednesday, September 21, 2022 4:37 PM > *To:* Wu, Hao A > *Cc:

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-22 Thread Wu, Hao A
to double check if the change is really what you want to do? Best Regards, Hao Wu From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Wednesday, September 21, 2022 4:37 PM To: Wu, Hao A Cc: devel@edk2.groups.io; Ni, Ray Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-21 Thread Sean Rhodes
o quickly figure out the > whole picture with only log being provided. > > > > Best Regards, > > Hao Wu > > > > *From:* Sean Rhodes > *Sent:* Wednesday, September 21, 2022 4:01 PM > *To:* Wu, Hao A > *Cc:* devel@edk2.groups.io; Ni, Ray > *Subject:* Re:

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-21 Thread Wu, Hao A
Sent: Wednesday, September 21, 2022 4:01 PM To: Wu, Hao A Cc: devel@edk2.groups.io; Ni, Ray Subject: Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path Hi Hao I've attached a debug log for the problem I'm trying to solve (these two patches solve it). The reset

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-21 Thread Sean Rhodes
tStatus()? Thanks in advance. > > Also, one inline comment below: > > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Sean > > Rhodes > > Sent: Tuesday, September 20, 2022 9:14 PM > > To: devel@edk2.groups.io > > Cc: Rhodes, Sean ; Wu, Hao A

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-20 Thread Wu, Hao A
e. Also, one inline comment below: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Rhodes > Sent: Tuesday, September 20, 2022 9:14 PM > To: devel@edk2.groups.io > Cc: Rhodes, Sean ; Wu, Hao A > ; Ni, Ray > Subject: [edk2-devel] [PATCH 1/2] MdeMo

[edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-20 Thread Sean Rhodes
Zero out the PortState in case GetPortStatus didn't set it, to avoid continuing with EFI_DEVICE_ERROR. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Sean Rhodes --- MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c | 5 + 1 file changed, 5 insertions(+) diff --git