Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add support for Firmware Volume Block Protocol

2022-02-14 Thread Guo Dong
Hi Sean, This is a big patch. Here are some high level comments. For BlSMMStoreDxe/BlSMMStoreDxe.inf, how about rename it to SmmStoreFvb/SmmStoreFvbRuntimeDxe.inf with below reasons? a) We don't need "Bl" since Payload would always work with bootloader. b) We could keep "SMMStore" but I prefer

[edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add support for Firmware Volume Block Protocol

2022-02-11 Thread Sean Rhodes
From: Patrick Rudolph This adds support for FVB in order to support a platform independent and non-volatile variable store on UefiPayloadPkg. It is required for non-volatile variable support, TPM support, Secureboot support and more. Since commit bc744f5893fc4d53275ed26dd8d968011c6a09c1 coreboot