A following patch is adding support for building StMM in order to run it
from OP-TEE.
OP-TEE in combination with a NS-world supplicant can use the RPMB
partition of an eMMC to store EFI variables. The supplicant
functionality is currently available in U-Boot only but can be ported
into EDK2. Assumi
Ilias
Apalodimas via groups.io
*Sent:* Friday, February 12, 2021 5:34 PM
*To:* devel@edk2.groups.io ; Sami Mujawar
*Cc:* ardb+tianoc...@kernel.org ;
sughosh.g...@linaro.org ; l...@nuviainc.com
; Ilias Apalodimas
*Subject:* [edk2-devel] [PATCH 1/2 v5] Drivers/OpTeeRpmb: Add an
OP-TEE backed RPMB
Hi Pierre,
On Wed, Mar 03, 2021 at 10:20:17AM +, Pierre wrote:
> Hello Ilias,
>
> My review is mostly about coding style, but I would have some (inlined)
> remarks about your patch,
>
> Regards,
>
> Pierre
>
> On 3/2/21 3:35 PM, Pierre Gondois wrote:
>
> >
> >
[...]
> > + offer that
Hi Ilias,
Thanks for the answers, I am re-reviewing the patch because I think I
missed some things. I answered to your comments (inlined),
Regards,
Pierre
On 3/3/21 8:02 PM, Ilias Apalodimas wrote:
Hi Pierre,
On Wed, Mar 03, 2021 at 10:20:17AM +, Pierre wrote:
Hello Ilias,
My review
Hi Ilias,
Here is the rest of the review. Sorry to do it in 2 times.
Regards,
Pierre
+/**
+ Fixup the Pcd values for variable storage
+
+ Since the upper layers of EDK2 expect a memory mapped interface and
we can't
+ offer that from an RPMB, the driver allocates memory on init and
On Fri, Mar 05, 2021 at 05:58:49PM +, Pierre wrote:
> Hi Ilias,
> Here is the rest of the review. Sorry to do it in 2 times.
No worries, I'll try to pick up all the comments.
>
> Regards,
>
> Pierre
>
>
> >
> > +/**
> >
> > + Fixup the Pcd values for variable storage
> >
> > +
> >
> > + Sin
