Hi Girish,
Apologies for the delay in reply.
Please find my response marked inline as [SAMI].
Regards,
Sami Mujawar
On 28/01/2023 12:09 am, Girish Mahadevan wrote:
Hi Sami
Sorry for the long silence. I've sent you v2 of the patch (only
framework not the Type17) which includes a link to a
Hi Sami
Sorry for the long silence. I've sent you v2 of the patch (only
framework not the Type17) which includes a link to a github branch.
Few more comments inline , prefixed by [GM].
Best Regards
Girish
On 10/18/2022 9:36 AM, Sami Mujawar via groups.io wrote:
*External email: Use caution
Hi Girish,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 04/10/2022 11:43 pm, Girish Mahadevan via groups.io wrote:
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the handle manager [GM].
Best Regards
Hello Sami
Thank you so much for your review, I apologize for the late response.
My comment in line about the handle manager [GM].
Best Regards
Girish
On 9/12/2022 8:57 AM, Sami Mujawar wrote:
External email: Use caution opening links or attachments
Hi Girish,
Thank you for this patch and
ia.com) ; Ashish Singhal
> ; Akanksha Jain ;
> Matteo Carlini ; Hemendra Dassanayake
> ; Nick Ramirez ;
> William Watson ; nd
> Subject: Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: Add Smbios Type17
> Table generator
>
> Caution: This message originated from an Ex
> ; Hemendra Dassanayake
> ; Nick Ramirez ;
> William Watson ; Akanksha Jain
> ; n...@arm.com
> Subject: Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: Add Smbios
> Type17 Table generator
...
> > +STATIC
> > +EFI_STATUS
>
dorov
> Cc: Samer El-Haj-Mahmoud ; Jeff
> Brasen ; Ashish Singhal ;
> Akanksha Jain ; Matteo Carlini
> ; Hemendra Dassanayake
> ; Nick Ramirez ;
> William Watson ; Akanksha Jain
> ; n...@arm.com
> Subject: Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: Add Smbios
> Type17
Hi Girish,
Thank you for this patch and for the effort for bringing forward dynamic
SMBIOS generation.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 26/08/2022 06:37 pm, Girish Mahadevan wrote:
Add a new CM object to describe memory devices and setup a new
Add a new CM object to describe memory devices and setup a new
Generator Library for SMBIOS Type17 table.
Signed-off-by: Girish Mahadevan
---
.../Include/ArmNameSpaceObjects.h | 59 +++
.../SmbiosType17Lib/SmbiosType17Generator.c | 338 ++
