Re: [edk2-devel] [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

2021-06-11 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 08-Jun-21 15:06, Laszlo Ersek wrote: Insert a SHA256 CHAP_HASH structure at the start of "mChapHash". Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32). This enables the initiator and the target to negotiate SHA256 for CHAP, in preference to MD5. Cc:

Re: [edk2-devel] [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

2021-06-09 Thread Philippe Mathieu-Daudé
On 6/8/21 3:06 PM, Laszlo Ersek wrote: > Insert a SHA256 CHAP_HASH structure at the start of "mChapHash". > > Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32). > > This enables the initiator and the target to negotiate SHA256 for CHAP, in > preference to MD5. > > Cc: Jiaxin Wu >

[edk2-devel] [PATCH 5/6] NetworkPkg/IScsiDxe: support SHA256 in CHAP

2021-06-08 Thread Laszlo Ersek
Insert a SHA256 CHAP_HASH structure at the start of "mChapHash". Update ISCSI_CHAP_MAX_DIGEST_SIZE to SHA256_DIGEST_SIZE (32). This enables the initiator and the target to negotiate SHA256 for CHAP, in preference to MD5. Cc: Jiaxin Wu Cc: Maciej Rabeda Cc: Philippe Mathieu-Daudé Cc: Siyuan