Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

2023-05-25 Thread Tuan Phan
On Thu, May 25, 2023 at 7:27 AM Ard Biesheuvel wrote: > On Wed, 24 May 2023 at 20:13, Tuan Phan wrote: > > > > > > > > On Mon, Mar 6, 2023 at 9:53 AM Ard Biesheuvel wrote: > >> > >> On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: > >> > > >> > The flash base address can be added to GCD before th

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

2023-05-25 Thread Ard Biesheuvel
On Wed, 24 May 2023 at 20:13, Tuan Phan wrote: > > > > On Mon, Mar 6, 2023 at 9:53 AM Ard Biesheuvel wrote: >> >> On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: >> > >> > The flash base address can be added to GCD before this driver run. >> > So only add it if it has not been done. >> > >> >> How

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

2023-05-24 Thread Tuan Phan
On Mon, Mar 6, 2023 at 9:53 AM Ard Biesheuvel wrote: > On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: > > > > The flash base address can be added to GCD before this driver run. > > So only add it if it has not been done. > > > > How do you end up in this situation? > > You cannot skip this regist

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

2023-03-06 Thread Ard Biesheuvel
On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: > > The flash base address can be added to GCD before this driver run. > So only add it if it has not been done. > How do you end up in this situation? You cannot skip this registration, as it is required to get the region marked as EFI_MEMORY_RUNTIM

[edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

2023-03-06 Thread Tuan Phan
The flash base address can be added to GCD before this driver run. So only add it if it has not been done. Signed-off-by: Tuan Phan --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c | 25 +++ 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/OvmfPkg/VirtNorFlashDxe/V