Ray,
Thanks for the comments. I'll modify the code in next version patch set.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Friday, March 31, 2023 3:01 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Bi, Dandan ; Gao, Liming ;
Wang, Jian J
Subject: RE: [PATCH 7/9] MdeModulePkg/DxeIpl:
Thanks for the cleanup: 166(+) 679(-).
2 minor comments:
> UINTN
> CreateIdentityMappingPageTables (
> + IN BOOLEAN Is32BitPageTable,
[Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit is
the trend, I don't like to say future is "FALSE".
> + MapAttribute
Modify CreateIdentityMappingPageTables() to create page table
based on CpuPageTableLib in DxeIpl module. This function can
be used to create both IA32 PAE paging and long mode 4-level,
5-level paging structure. With the PageTableMap() API in the
CpuPageTableLib, we can remove the complicated page t
