Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-06 Thread James Bottomley
On Thu, 2021-05-06 at 13:57 +0300, Dov Murik wrote: > > On 05/05/2021 22:33, Laszlo Ersek wrote: > > On 05/05/21 15:11, Brijesh Singh wrote: > > > On 5/5/21 1:42 AM, Dov Murik wrote: [...] > > > > Would it make sense to always use EfiACPIMemoryNVS for the > > > > injected secret area, even for reg

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-06 Thread James Bottomley
On Wed, 2021-05-05 at 21:33 +0200, Laszlo Ersek wrote: > On 05/05/21 15:11, Brijesh Singh wrote: > > On 5/5/21 1:42 AM, Dov Murik wrote: [...] > > > Would it make sense to always use EfiACPIMemoryNVS for the > > > injected secret area, even for regular SEV (non-SNP)? > > > > Ideally yes. Maybe Jam

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-06 Thread Laszlo Ersek
Hi Dov, On 05/06/21 12:57, Dov Murik wrote: > > > On 05/05/2021 22:33, Laszlo Ersek wrote: >> On 05/05/21 15:11, Brijesh Singh wrote: >>> >>> On 5/5/21 1:42 AM, Dov Murik wrote: [+cc: Tobin] Hi Brijesh, On 30/04/2021 14:51, Brijesh Singh wrote: > BZ: > https://n

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-06 Thread Dov Murik
On 05/05/2021 22:33, Laszlo Ersek wrote: > On 05/05/21 15:11, Brijesh Singh wrote: >> >> On 5/5/21 1:42 AM, Dov Murik wrote: >>> [+cc: Tobin] >>> >>> Hi Brijesh, >>> >>> On 30/04/2021 14:51, Brijesh Singh wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbug

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-05 Thread Laszlo Ersek
On 05/05/21 15:11, Brijesh Singh wrote: > > On 5/5/21 1:42 AM, Dov Murik wrote: >> [+cc: Tobin] >> >> Hi Brijesh, >> >> On 30/04/2021 14:51, Brijesh Singh wrote: >>> BZ: >>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-05 Thread Brijesh Singh
On 5/5/21 1:42 AM, Dov Murik wrote: > [+cc: Tobin] > > Hi Brijesh, > > On 30/04/2021 14:51, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C93168c94eb6d44ed

Re: [edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-05-04 Thread Dov Murik
[+cc: Tobin] Hi Brijesh, On 30/04/2021 14:51, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > When AMD SEV is enabled in the guest VM, a hypervisor need to insert a > secrets page. > > When SEV-SNP is enabled, the secrets page contains the VM platform > commun

[edk2-devel] [PATCH RFC v2 11/28] OvmfPkg: Reserve Secrets page in MEMFD

2021-04-30 Thread Brijesh Singh
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 When AMD SEV is enabled in the guest VM, a hypervisor need to insert a secrets page. When SEV-SNP is enabled, the secrets page contains the VM platform communication keys. The guest BIOS and OS can use this key to communicate with the SEV fi