Re: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier

2020-02-17 Thread Zeng, Star
: devel@edk2.groups.io; Zeng, Star > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: > Match data type and format specifier > > Reviewed-by: Eric Dong > > -Original Message- > From: devel@edk2.groups.io On Be

Re: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier

2020-02-04 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Zeng, Star Sent: Tuesday, February 4, 2020 3:02 PM To: devel@edk2.groups.io Cc: Zeng, Star ; Dong, Eric ; Ni, Ray ; Laszlo Ersek Subject: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match

Re: [edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier

2020-02-04 Thread Laszlo Ersek
On 02/04/20 08:02, Star Zeng wrote: > Match data type and format specifier for printing. > 1. Type cast ProcessorNumber and FeatureIndex to UINT32 > as %d only expects a UINT32. > 2. Use %08x instead of %08lx for CacheControl to print Index > as it is UINT32 type. > 3. Use %016lx instead of %08

[edk2-devel] [PATCH V2] UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier

2020-02-03 Thread Zeng, Star
Match data type and format specifier for printing. 1. Type cast ProcessorNumber and FeatureIndex to UINT32 as %d only expects a UINT32. 2. Use %08x instead of %08lx for CacheControl to print Index as it is UINT32 type. 3. Use %016lx instead of %08lx for MemoryMapped to print (Index | LShiftU6