Hi,
> > 2. Can SourceLevelDebug (rely on Local APIC timer) work if this driver is
> > chosen as DXE timer driver?
> After checking the code and running the PoC (enable SourceLevelDebug and
> LocalApicTimerDxe), I find this driver doesn't work anymore.
> Actually it asserts in
>
On November 22, 2021 11:05 AM, Ni Ray wrote:
> Min,
> What's the reason of moving this driver to UefiCpuPkg?
Please refer to the discussion in
https://edk2.groups.io/g/devel/topic/86735078#83126
Because localApicTimerDxe is hardware feature. There is no specific OVMF or
QEMU related thing there.
Thanks Ray.
I prefer to put the LocalApicTimerDxe to UefiCpuPkg, because it is hardware
feature.
There is no specific OVMF or QEMU related thing there. It does not make sense
to keep it to OvmfPkg.
Your quality concern is valid. I think the quality expectation for
LocalApicTimerDxe should be
Min,
What's the reason of moving this driver to UefiCpuPkg?
When the LocalApicTimerDxe is in OvmfPkg, it's clear that this driver is only
used by OVMF/QEMU platform.
Now since the patch moves the driver to UefiCpuPkg, it's possible that other
platforms may choose this driver as the timer driver
On Mon, Nov 08, 2021 at 02:08:00PM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
>
> OvmfPkg.dec is removed from [Packages] because it doesn't depend
> on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg.
>
> Cc: Jiewen Yao
> Cc: Gerd Hoffmann
> Cc: Anthony
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711
OvmfPkg.dec is removed from [Packages] because it doesn't depend
on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg.
Cc: Jiewen Yao
Cc: Gerd Hoffmann
Cc: Anthony Perard
Cc: Julien Grall
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Min Xu
