Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-19 Thread Ard Biesheuvel
On Fri, Dec 15, 2023 at 12:56 PM Mike Beaton wrote: > > > For the exception handler case, we can just drop the #Ifdefs around > > the definition of BaseName () entirely given that it will now always > > be referenced. But that does depend a lot on how other toolchains deal > > with this (VS201x

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-15 Thread Mike Beaton
> For the exception handler case, we can just drop the #Ifdefs around > the definition of BaseName () entirely given that it will now always > be referenced. But that does depend a lot on how other toolchains deal > with this (VS201x primarily) The V5/V6 version of the patch builds on VS2019

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-14 Thread Ard Biesheuvel
On Thu, 14 Dec 2023 at 08:40, Ard Biesheuvel wrote: > > On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote: > > > > From: Mike Beaton > > > > This is no longer required since the revised DEBUG macro automatically > > compiles away unused var accesses when MDEPKG_NDEBUG is defined; > > keeping

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-13 Thread Ard Biesheuvel
On Thu, 14 Dec 2023 at 08:28, Mike Beaton wrote: > > From: Mike Beaton > > This is no longer required since the revised DEBUG macro automatically > compiles away unused var accesses when MDEPKG_NDEBUG is defined; > keeping these lines is incompatible with the updated DEBUG macro, as > there has

Re: [edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-13 Thread Mike Beaton
Hi, I'm not fully used to email-based git commits. In this case, I've got two commits with different messages which are meant to make one patch set. I was under the impression that the first line of each commit is taken from the subject, but in that case these cease to appear as one thread in

[edk2-devel] [PATCH V4 2/2] ArmPkg: Remove manual exclusion of debug vars when MDEPKG_NDEBUG is not defined

2023-12-13 Thread Mike Beaton
From: Mike Beaton This is no longer required since the revised DEBUG macro automatically compiles away unused var accesses when MDEPKG_NDEBUG is defined; keeping these lines is incompatible with the updated DEBUG macro, as there has to be a variable, access to which to discard. Signed-off-by: