Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Ard Biesheuvel
On Fri, 17 Feb 2023 at 18:31, Pedro Falcato wrote: > > On Fri, Feb 17, 2023 at 3:38 PM Marvin Häuser wrote: > > > > > > > On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > > > > > So the FAT driver will happily load, but then fail in an obscure > > > manner when being started on a controller

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Pedro Falcato
On Fri, Feb 17, 2023 at 3:38 PM Marvin Häuser wrote: > > > > On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > > > So the FAT driver will happily load, but then fail in an obscure > > manner when being started on a controller handle, in a way that is > > indistinguishable (afict) from a partit

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Marvin Häuser
> On 17. Feb 2023, at 16:17, Ard Biesheuvel wrote: > > So the FAT driver will happily load, but then fail in an obscure > manner when being started on a controller handle, in a way that is > indistinguishable (afict) from a partition that has not FAT file > system in the first place. > > So it

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Ard Biesheuvel
On Fri, 17 Feb 2023 at 15:55, Marvin Häuser wrote: > > > > On 17. Feb 2023, at 15:29, Ard Biesheuvel wrote: > > > > On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: > >> > >> Hi Ard, > >> > >> Thank you! Is "1/4" a mistake or did I miss the other 3? :) > > > > Oops. > > > > It was part of som

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Marvin Häuser
> On 17. Feb 2023, at 15:29, Ard Biesheuvel wrote: > > On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: >> >> Hi Ard, >> >> Thank you! Is "1/4" a mistake or did I miss the other 3? :) > > Oops. > > It was part of some RPi4 patches but I decided to send it out by itself. > > >> Comment

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Ard Biesheuvel
On Fri, 17 Feb 2023 at 15:05, Marvin Häuser wrote: > > Hi Ard, > > Thank you! Is "1/4" a mistake or did I miss the other 3? :) Oops. It was part of some RPi4 patches but I decided to send it out by itself. > Comments inline. > > On 17. Feb 2023, at 12:12, Ard Biesheuvel wrote: > > The Unicode

Re: [edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Marvin Häuser
Hi Ard, Thank you! Is "1/4" a mistake or did I miss the other 3? :) Comments inline. > On 17. Feb 2023, at 12:12, Ard Biesheuvel wrote: > > The Unicode collation protocols, however, are different: loading the > driver will fail if neither of those are present. So they are not > TO_START protoco

[edk2-devel] [PATCH edk2-platforms 1/4] Ext4Pkg: Use depex for unicode collation protocols

2023-02-17 Thread Ard Biesheuvel
The EXT4 driver implements the UEFI driver model, which means it can consume one protocol (marked with a TO_START comment in the .INF) and produce another (marked as BY_START). The TO_START protocols are not prerequisites for loading and starting the module, they are simply protocols the driver may