Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-20 Thread wenyi,xie via groups.io
On 2021/12/18 0:39, Sami Mujawar wrote: > Hi Ard, > > > On 17/12/2021, 16:34, "Ard Biesheuvel" wrote: > > On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > > > Hi Leif, Ard, Wenyi, > > > > Is it possible to review and provde feedback for this change, please? >

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Ard, On 17/12/2021, 16:34, "Ard Biesheuvel" wrote: On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? > I agree that this should be resolved, and I don't think it

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? > I agree that this should be resolved, and I don't think it matters which one we change. The INF GUIDs of libraries are never used anyway, as far

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Leif, Ard, Wenyi, Is it possible to review and provde feedback for this change, please? Regards, Sami Mujawar On 17/12/2021 02:15 PM, Pierre Gondois wrote: Hi Sami, You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf: "Based on the

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread PierreGondois
Hi Sami, You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf: "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/" Thanks for updating the commit, Regards, Pierre On 12/17/21 2:59 PM, Sami Mujawar wrote: >

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLibSec.inf -

[edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-11-24 Thread PierreGondois
From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLibSec.inf - Silicon/Hisilicon/Library/ ArmPlatformLibHisilicon/ArmPlatformLibSec.inf The inf file in the Platform/ARM/ folder is based on the one in