Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib

2023-01-25 Thread Sami Mujawar
Had an offline discussion with Pierre. Apparently there are additional issues that need to be fixed. So, please ignore this patch series and instead use the patch series from Pierre at https://edk2.groups.io/g/devel/message/99012 Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib

2023-01-25 Thread Sami Mujawar
On Mon, Jan 23, 2023 at 12:08 AM, PierreGondois wrote: > > forms have the same library missing: > - Platform/Hisilicon/D03/D03.dsc > - Platform/Hisilicon/D06/D06.dsc > - Platform/Hisilicon/HiKey960/HiKey960.dsc > - Platform/Hisilicon/HiKey/HiKey.dsc > > If the library definition is done in Silic

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib

2023-01-23 Thread PierreGondois
Hi Sami, I think other platforms have the same library missing: - Platform/Hisilicon/D03/D03.dsc - Platform/Hisilicon/D06/D06.dsc - Platform/Hisilicon/HiKey960/HiKey960.dsc - Platform/Hisilicon/HiKey/HiKey.dsc If the library definition is done in Silicon/Hisilicon/Hisilicon.dsc.inc, I think it so

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Hisilicon: Fix missing dependency on VariableFlashInfoLib

2023-01-19 Thread Sami Mujawar
From: Guillaume Gardet The Hisilicon/HiKey and Hisilicon/HiKey960 platform firmware builds break due to a missing dependency on VariableFlashInfoLib. Therefore, include VariableFlashInfoLib in the [LibraryClasses.common] section to satisfy the dependency. Cc: Leif Lindholm Cc: Ard Biesheuvel