Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-14 Thread Masahisa Kojima
Hi Sami, On Thu, 14 Jul 2022 at 17:01, Sami Mujawar wrote: > > Hi Masahisa, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 14/07/2022 07:38 am, Masahisa Kojima wrote: > > Hi Sami, > > > > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > > also

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-14 Thread Sami Mujawar
Hi Pierre, Thank you for the review. I have some comments marked inline as [SAMI]. Regards, Sami Mujawar On 14/07/2022 09:01 am, Sami Mujawar wrote: Hi Masahisa, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 14/07/2022 07:38 am, Masahisa Kojima wrote: Hi Sami,

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-14 Thread Sami Mujawar
Hi Masahisa, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 14/07/2022 07:38 am, Masahisa Kojima wrote: Hi Sami, Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc also requires the VariableFlashInfoLib library. I have checked that the build error is fixed with the

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-14 Thread Masahisa Kojima
Hi Sami, Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc also requires the VariableFlashInfoLib library. I have checked that the build error is fixed with the following modification. --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc +++

Re: [edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-13 Thread PierreGondois
Hi Sami, I think Silicon/NXP/NxpQoriqLs.dsc.inc also requires the VariableFlashInfoLib library. Otherwise: Reviewed-by: Pierre Gondois On 7/12/22 16:40, Sami Mujawar wrote: This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00

[edk2-devel] [PATCH edk2-platforms v3 00/12] Fix build breaks and update IORT revision macro

2022-07-12 Thread Sami Mujawar
This v3 patch series renames the EFI_ACPI_IO_REMAPPING_TABLE_REV0 macro to EFI_ACPI_IO_REMAPPING_TABLE_REVISION_00 based on the feedback received. It also includes an additional patch that fixes the build break in CelloBoard due to missing VariablePolicyHelperLib dependency. The v2 patch series