Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-14 Thread Nhi Pham via groups.io
Oops, sorry. I just realized :) Reviewed-by: Nhi Pham Thanks, -Nhi On 14/07/2022 16:06, Sami Mujawar wrote: Hi Nhi, Looks like the file Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in upstream edk2-platforms. See

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-14 Thread Sami Mujawar
Hi Nhi, Looks like the file Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc is not in upstream edk2-platforms. See https://github.com/tianocore/edk2-platforms/tree/master/Silicon/Ampere/AmpereAltraPkg Regards, Sami Mujawar On 14/07/2022 08:40 am, Sami Mujawar via groups.io

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-14 Thread Sami Mujawar
Hi Nhi, I will do that no problem. However, we really need an edk2-platforms CI to catch such issues. Regards, Sami Mujawar On 14/07/2022 04:34 am, Nhi Pham wrote: Hi Sami, Could you help update for Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? Thanks, Nhi On

Re: [edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-13 Thread Nhi Pham via groups.io
Hi Sami, Could you help update for Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? Thanks, Nhi On 12/07/2022 21:40, Sami Mujawar wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Add an instance for the library class VariableFlashInfoLib that was

[edk2-devel] [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib

2022-07-12 Thread Sami Mujawar
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 Add an instance for the library class VariableFlashInfoLib that was recently introduced in MdeModulePkg. This allows the variable driver to build successfully as it has a dependency on this library class. Signed-off-by: Sami Mujawar ---