Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Fix SetLargeVariable fail issue

2023-05-10 Thread Zhang, Xiaoqiang
Thanks Nate for the comprehensive proposal! Since I found SetLargeVariable only used in SaveMemoryConfig DXE driver now, so how about we fix this issue first to unblock the verification on server platform. And after that, we can handle the case you mentioned. -Original Message- From: De

Re: [edk2-devel] [PATCH v1] MinPlatformPkg: Fix SetLargeVariable fail issue

2023-05-09 Thread Nate DeSimone
Great catch Xiaoqiang! Only issue I see is that for 100% correctness we will need to add a check to see if we are past ExitBootServices(). This issue is if we are in OS runtime and we try to overwrite an existing variable when there isn't enough space to do so without a reclaim... the current

[edk2-devel] [PATCH v1] MinPlatformPkg: Fix SetLargeVariable fail issue

2023-05-09 Thread Xiaoqiang Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4454 On Server platform, when the large variable "FspNvsBuffer" is already in the UEFI variable store and the remaining variable storage space is less than the large variable size. And also not in OS runtime then we need to add the size of the cu