[edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu

2023-03-13 Thread Wu, Jiaxin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4368 This issue is caused by the commit: ec07fd0e35d90dbcc36be300a9ceeac29c5de2ad GetFirstGuidHob() should not be used after exit boot service. Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ersek Cc: Gerd Hoffmann Signed-off-by: Jiaxin

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu

2023-03-13 Thread Ni, Ray
Jiaxin, Thanks for fixing the bug. Reviewed-by: Ray Ni > -Original Message- > From: Wu, Jiaxin > Sent: Monday, March 13, 2023 3:04 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Laszlo Ersek ; Gerd Hoffmann > > Subject: [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm:

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu

2023-03-13 Thread Gerd Hoffmann
Hi, > - // > - // Make sure the gSmmBaseHobGuid existence status is the same between > normal and S3 boot. > - // > - ASSERT (mSmmRelocated == (BOOLEAN)(GetFirstGuidHob (&gSmmBaseHobGuid) != > NULL)); > - if (mSmmRelocated != (BOOLEAN)(GetFirstGuidHob (&gSmmBaseHobGuid) != > NULL)) { > -

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu

2023-03-13 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Wu, Jiaxin Sent: Monday, March 13, 2023 3:04 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Zeng, Star ; Laszlo Ersek ; Gerd Hoffmann Subject: [PATCH v1] UefiCpuPkg/PiSmmCpuDxeSmm: Fix S3 failure in SmmRestoreCpu REF: https://b