Response below.
On 11/23/2021 3:19 PM, Kinney, Michael D wrote:
Hi Michael,
Comments below.
Mike
-Original Message-
From: Michael Kubacki
Sent: Tuesday, November 23, 2021 12:07 PM
To: Kinney, Michael D ; devel@edk2.groups.io
Cc: Liming Gao ; Sean Brogan
; Bret Barkelew
Subject: Re
Hi Michael,
Comments below.
Mike
> -Original Message-
> From: Michael Kubacki
> Sent: Tuesday, November 23, 2021 12:07 PM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Liming Gao ; Sean Brogan
> ; Bret Barkelew
>
> Subject: Re: [PATCH v1 1/1] .pytool/Plugin/Uncrustify: Add Uncr
I'll file a BZ and add it.
I don't see a difference comparing my template file contents against the
corresponding files in the branch you linked. Am I missing something?
I saw the temp file directory change recently added to those plugin
patches. My concern is that .pytool/ is tracked by git
Hi Michael,
Have you opened a BZ for this feature? Can you do that and add REF: to the
commit message?
Also, the template files for uncrustify need to be updated to match the contents
from the EDK II C Coding Standard. Pease see the file and function header
templates
in this location:
h
From: Michael Kubacki
Adds a new CI plugin for Uncrustify. This is used to check
coding standard compliance of source code to the EDK II C Coding
Standards Specification.
An external dependency is added in the plugin directory to retrieve
the Uncrustify executable. Currently, the executable is f
