[edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-12 Thread levi.yun
Currently, GTDT only prints the value of timer flags in hex. This change prints the detail informaiton about Timer flags in GTDT. before: Shell> acpiview -s GTDT ... Non-Secure EL1 timer FLAGS : 0x2 Virtual timer GSIV : 0x1B Virtual timer FLAGS

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-13 Thread PierreGondois
Hello Levi, The patch looks good to me, also: Tested-by: Pierre Gondois Regards, Pierre On 7/12/23 13:44, levi.yun wrote: Currently, GTDT only prints the value of timer flags in hex. This change prints the detail informaiton about Timer flags in GTDT. before: Shell> acpiview -s GTDT

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-13 Thread Pedro Falcato
Nit: AcpiView, not Acpivew On Wed, Jul 12, 2023 at 4:16 PM levi.yun wrote: > > Currently, GTDT only prints the value of timer flags in hex. > This change prints the detail informaiton about Timer flags in GTDT. Nit: information > > before: > Shell> acpiview -s GTDT > ... > Non-Secure

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Acpivew/GTDT: Print timer flags information.

2023-07-14 Thread levi.yun
t;> >> +/** >> >> + This function prints Polarity information in timer flags. > polarity (lowercase) Thanks. Many Thanks..! ________________ From: Pedro Falcato Sent: 13 July 2023 15:24 To: devel@edk2.groups.io; Yeo Reum Yun Cc: zhichao@int