[edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-10-20 Thread Chris Jones
Add a comment to clarify that in Acpiview the ItemPtr is not set until after the FieldValidator has been called. Signed-off-by: Chris Jones --- ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiSh

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-10-27 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Sami Mujawar > Sent: Wednesday, October 20, 2021 6:54 PM > To: Christopher Jones ; > devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; nd > > Subject: Re: [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set af

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-11-08 Thread Chris Jones
Hi, It looks like this patch has recieved the relevant approvals and is ready for merge. Could this patch please be merged in time for the edk2-stable202111 release. Thanks, Chris From: Gao, Zhichao Sent: Thursday, October 28, 2021 4:15 AM To: Sami Mujawar ; Ch

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

2021-10-20 Thread Sami Mujawar
Hi Chris, Thanks for adding the comment that clarifies the usage. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 20/10/2021, 11:47, "Chris Jones" wrote: Add a comment to clarify that in Acpiview the ItemPtr is not set until after the FieldValidator has been called. Signed-