Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix bug in ScsiBusDxe/ScsiBus.c

2023-01-30 Thread Yuan Yu via groups.io
Hi Hao Wu, Thank you very much for the review and the detailed advice, which is much appreciated! I have made the changes accordingly and sent patch v2. Please take another look. Thank you! Yuan On Wed, Jan 18, 2023 at 10:33 PM Wu, Hao A wrote: > Thanks for the patch, inline comments below:

Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix bug in ScsiBusDxe/ScsiBus.c

2023-01-18 Thread Wu, Hao A
Thanks for the patch, inline comments below: > -Original Message- > From: Yuan Yu > Sent: Wednesday, January 18, 2023 5:14 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gao, Liming > ; Wu, Hao A ; Ni, Ray > ; C, sivaparvathi > Subject: [PATCH v1 1/2] MdeModulePkg: Fix bug in Scsi

[edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix bug in ScsiBusDxe/ScsiBus.c

2023-01-18 Thread Yuan Yu via groups.io
A while loop in SCSIBusDriverBindingStart() is supposed to scan all the possible Puns in the SCSI channel by calling ScsiScanCreateDevice() for each of them. Therefore, we should not abort the loop even when one of the Puns is disconnected. The following is one of the scenarios. SCSIBusDriverBind