Re: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

2023-10-05 Thread Leif Lindholm
;. Regards, Leif > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Ranbir > > Singh > > Sent: Tuesday, October 3, 2023 10:48 PM > > To: devel@edk2.groups.io; rsi...@ventanamicro.com > > Cc: Wu, Hao A ; Ni, Ray ; > > Veeresh Sango

Re: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

2023-10-04 Thread Ranbir Singh
A ; Ni, Ray ; > > Veeresh Sangolli > > Subject: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: > > Fix MISSING_BREAK Coverity issues > > > > From: Ranbir Singh > > > > The function GetNextHidItem has a switch-case code in which the >

Re: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

2023-10-04 Thread Michael D Kinney
gh > Sent: Tuesday, October 3, 2023 10:48 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A ; Ni, Ray ; > Veeresh Sangolli > Subject: [edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: > Fix MISSING_BREAK Coverity issues > > From: Ranbir Singh

[edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Usb/UsbMouseDxe: Fix MISSING_BREAK Coverity issues

2023-10-03 Thread Ranbir Singh
From: Ranbir Singh The function GetNextHidItem has a switch-case code in which the case 1: falls through to case 2: and then case 2: falls through to case 3: in the block. While this may be intentional, it is not evident to any general code reader as well as any static analyzer tool. Just adding