[edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-02-09 Thread Ming Huang
The heap space will be rewrote if a StandloneMmPkg module create HOB by BuildGuidHob() interface and write data to HOB space. Add a PCD PcdMemoryHobSize for pre-allocation a space to create HOB to fix this issue. Signed-off-by: Ming Huang --- StandaloneMmPkg/Core/StandaloneMmCore.c | 17 ++

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-08-16 Thread Nhi Pham via groups.io
Hi Ard and Ming, I have been seeing an issue with StandaloneMM HobLib that can be fixed by this patch as well. The function CreateHob() in the HobLib instance StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf does not work at all. The HobList is early created by the

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-08-28 Thread Nhi Pham via groups.io
Just a gentle ping! Hi Ard, can you provide your feedback on this patch? Thanks, -Nhi On 8/16/2023 3:55 PM, Nhi Pham via groups.io wrote: Hi Ard and Ming, I have been seeing an issue with StandaloneMM HobLib that can be fixed by this patch as well. The function CreateHob() in the HobLib i

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-08-30 Thread Ard Biesheuvel
On Wed, 16 Aug 2023 at 10:56, Nhi Pham wrote: > > Hi Ard and Ming, > > I have been seeing an issue with StandaloneMM HobLib that can be fixed > by this patch as well. > > The function CreateHob() in the HobLib instance > StandaloneMmPkg/Library/StandaloneMmCoreHobLib/StandaloneMmCoreHobLib.inf > d

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-08-31 Thread Nhi Pham via groups.io
Hi Ard, Thanks for your response on this patch. Please see my reply inline... On 8/30/2023 8:10 PM, Ard Biesheuvel wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] On Wed

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-01 Thread Oliver Smith-Denny
On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: Hi Ard, Thanks for your response on this patch. Please see my reply inline... On 8/30/2023 8:10 PM, Ard Biesheuvel wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and prop

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-04 Thread Nhi Pham via groups.io
Hi Oliver, thank you for taking a look at this patch. On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: Hi Ard, Thanks for your response on this patch. Please see my reply inline... On 8/30/2023 8:10 PM, Ard Biesheuvel wrote: [EXTERNAL EMAIL NO

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-05 Thread Oliver Smith-Denny
On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are created in StMM, i.e. not from HOBs that are passed in. Is this correct? Yes, the iss

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-05 Thread Ni, Ray
a.com ; Sami Mujawar ; Ard Biesheuvel ; Yao, Jiewen ; Supreeth Venkatesh ; ming.hua...@outlook.com Subject: Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue On 9/4/2023 7:20 PM, Nhi Pham wrote: > On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote:

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-05 Thread Ard Biesheuvel
On Wed, 6 Sept 2023 at 08:33, Ni, Ray wrote: > > I am a bit confused. > > The HOB list in standalone MM is read-only. Why could any module call > BuildGuidHob() to modify the HOB. > > I saw Oliver mentioned something about StMM. I don't know what that is. But > it seems that's ARM specific. Then

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-06 Thread Nhi Pham via groups.io
On 9/6/2023 4:29 AM, Oliver Smith-Denny wrote: On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are created in StMM, i.e. not from HOBs

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-06 Thread Nhi Pham via groups.io
devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue On 9/4/2023 7:20 PM, Nhi Pham wrote: On 9/2/2023 3:43 AM, Oliver Smith-Denny wrote: On 8/31/2023 1:20 AM, Nhi Pham via groups.io wrote: If I am understanding this correctly, this is only an issue when HOBs are creat

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-06 Thread Ard Biesheuvel
On Wed, 6 Sept 2023 at 09:56, Nhi Pham wrote: > > On 9/6/2023 1:33 PM, Ni, Ray wrote: > > [EXTERNAL EMAIL NOTICE: This email originated from an external sender. > > Please be mindful of safe email handling and proprietary information > > protection practices.] > > > > I am a bit confused. > > > >

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-06 Thread Oliver Smith-Denny
On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: On Wed, 6 Sept 2023 at 09:56, Nhi Pham wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and proprietary information protection practices.] I am

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-09-07 Thread Nhi Pham via groups.io
On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: On Wed, 6 Sept 2023 at 09:56, Nhi Pham wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: [EXTERNAL EMAIL NOTICE: This email originated from an external sender. Please be mindful of safe email handling and pro

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-11-30 Thread Nhi Pham via groups.io
On 9/7/2023 10:38 PM, Nhi Pham wrote: > On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: >> On 9/6/2023 1:50 AM, Ard Biesheuvel wrote: >>> On Wed, 6 Sept 2023 at 09:56, Nhi Pham >>> wrote: On 9/6/2023 1:33 PM, Ni, Ray wrote: > [EXTERNAL EMAIL NOTICE: This email originated from an exte

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2023-11-30 Thread Ni, Ray
wen ; Supreeth Venkatesh > ; ming.hua...@outlook.com > Subject: Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space > and heap space conflicted issue > > On 9/7/2023 10:38 PM, Nhi Pham wrote: > > On 9/6/2023 11:22 PM, Oliver Smith-Denny wrote: > >> On 9/6/20

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-05-03 Thread Ard Biesheuvel
On Wed, 9 Feb 2022 at 13:26, Ming Huang wrote: > > The heap space will be rewrote if a StandloneMmPkg module create HOB > by BuildGuidHob() interface and write data to HOB space. Can you elaborate? What is supposed to happen and why, and what is happening instead? > Add a PCD PcdMemoryHobSize fo

Re: [edk2-devel] [PATCH v1 2/2] StandaloneMmPkg: Fix HOB space and heap space conflicted issue

2022-05-12 Thread Ming Huang
在 5/3/22 5:10 PM, Ard Biesheuvel 写道: > On Wed, 9 Feb 2022 at 13:26, Ming Huang wrote: >> >> The heap space will be rewrote if a StandloneMmPkg module create HOB >> by BuildGuidHob() interface and write data to HOB space. > > Can you elaborate? What is supposed to happen and why, and what is >