Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

2023-06-30 Thread Kun Qin
Hi Pierre, Thanks for the example. If we are to keep this in one commit, I think we should mention SecurityPkg in the title? To follow the example, can we rename it to `SecurityPkg/SecurityPkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg`? At least this makes it more obvious that it is

Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

2023-06-30 Thread PierreGondois
Hello Kun, On 6/29/23 22:36, Kun Qin wrote: This patch seems to have some discrepancy between the title and content :) I'm not sure I see the discrepancy between the title/content, should I have mentioned the SecurityPkg ? Can you please break this patch into 2, so that MdePkg change and

Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

2023-06-29 Thread Kun Qin
This patch seems to have some discrepancy between the title and content :) Can you please break this patch into 2, so that MdePkg change and SecurityPkg can be their own commit? Thanks, Kun On 5/9/2023 12:40 AM, PierreGondois wrote: From: Pierre Gondois In order to use

Re: [edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

2023-06-29 Thread Sami Mujawar
Hi Pierre, Please see my response inline marked [SAMI]. With that fixed, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote: From: Pierre Gondois In order to use PcdCpuRngSupportedAlgorithm in the MdePkg in a following patch and to avoid

[edk2-devel] [PATCH v1 2/8] MdePkg/MdePkg.dec: Move PcdCpuRngSupportedAlgorithm to MdePkg

2023-05-09 Thread PierreGondois
From: Pierre Gondois In order to use PcdCpuRngSupportedAlgorithm in the MdePkg in a following patch and to avoid making the MdePkg dependent on another package, move PcdCpuRngSupportedAlgorithm to the MdePkg. As the Pcf is only used for AARCH64, place it in an AARCH64 specific sections.