Hi Pierre,
Thank you for this patch.
Please find my response inline marked [SAMI].
Other than the concern mentioned below, this patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote:
From: Pierre Gondois
BZ:
Hello,
The mantis ticket (created by Jose Marinho) is available at:
https://mantis.uefi.org/mantis/view.php?id=2386
Also, are there any comments on the patch-set ?
Regards,
Pierre
On 5/9/23 15:50, Samer El-Haj-Mahmoud wrote:
Hi Jiewen,
There is an open ECR for UEFI spec review:
Got it. Before that, I believe you can add the extension in MdeModulePkg or
SecurityPkg.
> -Original Message-
> From: Samer El-Haj-Mahmoud
> Sent: Tuesday, May 9, 2023 9:50 PM
> To: Yao, Jiewen ; Pierre Gondois
> ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu,
Hi Jiewen,
There is an open ECR for UEFI spec review:
https://bugzilla.tianocore.org/show_bug.cgi?id=4441. These patches can wait on
the list until the ECR is reviewed by UEFI Forum and the decision is documented
in the BZ. If approved, then the code patches should be able to proceed.
Thanks,
Is this defined in UEFI spec? or approved in future UEFI spec?
> -Original Message-
> From: pierre.gond...@arm.com
> Sent: Tuesday, May 9, 2023 3:41 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang ; Yao,
> Jiewen ; Wang, Jian J ; Ard
> Biesheuvel ;
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4441
The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple
implementations, some of them are unsafe (e.g. BaseRngLibTimerLib).
To allow the RngDxe to detect when such implementation is used,
a GetRngGuid()
