Re: [edk2-devel] [PATCH v1 6/8] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-06-29 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. I think we should treat algorithms that have a zero GUID as unsafe. I have made some suggestions on those lines marked inline as [SAMI]. Regards, Sami Mujawar On 09/05/2023 08:40 am, pierre.gond...@arm.com wrote: From: Pierre Gondois

[edk2-devel] [PATCH v1 6/8] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib

2023-05-09 Thread PierreGondois
From: Pierre Gondois BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4151 The EFI_RNG_PROTOCOL can rely on the RngLib. The RngLib has multiple implementations, some of them are unsafe (e.g. BaseRngLibTimerLib). To allow the RngDxe to detect when such implementation is used, a GetRngGuid()