Re: [edk2-devel] [PATCH v1 7/7] .pytool/Plugin: Add DebugMacroCheck

2023-09-07 Thread Michael Kubacki
There's not package level control at the moment from a given package CI YAML file. We've treated this as fundamental for "core" packages (those often built from a single CISettings.py file) and on-by-default but with a disable option via the env var for individual platform build files (like the

Re: [edk2-devel] [PATCH v1 7/7] .pytool/Plugin: Add DebugMacroCheck

2023-09-06 Thread Michael D Kinney
Reviewed-by: Michael D Kinney Really like the inclusion of unit tests. If any issues are found, can update unit test to cover that case. One quick question. I see a global disable through env var. I also see it says that is it runs on packages that use the compiler plugin. Is there a way to d

[edk2-devel] [PATCH v1 7/7] .pytool/Plugin: Add DebugMacroCheck

2023-08-14 Thread Michael Kubacki
From: Michael Kubacki Adds a plugin that finds debug macro formatting issues. These errors often creep into debug prints in error conditions not frequently executed and make debug more difficult when they are encountered. The code can be as a standalone script which is useful to find problems in