On Fri, 2021-11-12 at 01:27 +, Ni, Ray wrote:
[...]
> > +
> > + return (CurrentAttr == Attr);
>
> 2. I guess a "BOOLEAN" type cast is needed.
It shouldn't. Unless there's a major screw up in the way BOOLEAN works
in the UEFI API, all logic operations should already be of type BOOLEAN
and
On 11/11/21 7:27 PM, Ni, Ray wrote:
> 2 minor comments.
>
>> + switch (Attr) {
>> +case CCAttrAmdSev:
>> + return CurrentAttr >= CCAttrAmdSev;
>> +case CCAttrAmdSevEs:
>> + return CurrentAttr >= CCAttrAmdSevEs;
>> +case CCAttrAmdSevSnp:
>> + return CurrentAttr ==
2 minor comments.
> + switch (Attr) {
> +case CCAttrAmdSev:
> + return CurrentAttr >= CCAttrAmdSev;
> +case CCAttrAmdSevEs:
> + return CurrentAttr >= CCAttrAmdSevEs;
> +case CCAttrAmdSevSnp:
> + return CurrentAttr == CCAttrAmdSevSnp;
1. Can you put comments to
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275
Previous commit introduced a generic confidential computing PCD that can
determine whether AMD SEV-ES is enabled. Update the MpInitLib to drop the
PcdSevEsIsEnabled in favor of PcdConfidentialComputingAttr.
Cc: Michael Roth
Cc: Ray Ni
Cc:
