Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-20 Thread Pedro Falcato
On Sat, Dec 17, 2022 at 2:16 AM Tuan Phan wrote: > > > On Fri, Dec 16, 2022 at 5:59 PM Pedro Falcato > wrote: > >> On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney < >> michael.d.kin...@intel.com> wrote: >> >>> If that intrinsic is specific to RISCV, then should CompilerHelper.c go >>> into a

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
On Fri, Dec 16, 2022 at 4:06 PM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > If that intrinsic is specific to RISCV, then should CompilerHelper.c go > into a RiscV64 subdir? > > Mike > > Hi Mike, While this intrinsic is not specific to RISCV, it is needed due to the GCC for RISCV64

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
On Fri, Dec 16, 2022 at 5:59 PM Pedro Falcato wrote: > On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney < > michael.d.kin...@intel.com> wrote: > >> If that intrinsic is specific to RISCV, then should CompilerHelper.c go >> into a RiscV64 subdir? > > > Mike and Tuan, > > Two comments: > 1)

[edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-19 Thread Tuan Phan
The RiscV toolchain doesn't provide __ctzdi2 implementation when compiled with -nostdlib that needed by openssl library. So adding the implementation of __ctzdi2. Forcing to use CopyMem of EDK2 as memcpy buildin disabled for RiscV with -fno-builtin-memcpy flag. REF:

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-16 Thread Pedro Falcato
On Sat, Dec 17, 2022 at 12:06 AM Michael D Kinney < michael.d.kin...@intel.com> wrote: > If that intrinsic is specific to RISCV, then should CompilerHelper.c go > into a RiscV64 subdir? Mike and Tuan, Two comments: 1) __ctzdi2 is not riscv specific and is a part of the standard functions

Re: [edk2-devel] [PATCH v2] CryptoPkg/IntrinsicLib: RiscV: Provide implementation of memcpy and __ctzdi2

2022-12-16 Thread Michael D Kinney
If that intrinsic is specific to RISCV, then should CompilerHelper.c go into a RiscV64 subdir? Mike > -Original Message- > From: Tuan Phan > Sent: Friday, December 16, 2022 10:48 AM > Cc: devel@edk2.groups.io; suni...@ventanamicro.com; Kinney, Michael D > ; Yao, Jiewen > ; Wang, Jian