Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-25 Thread cbduggap
] IntelFsp2Pkg: Fsp 2.x Changes Thanks, Nate, for taking some time to review the patch. I agree that GlobalDatapointer usage to pass Top of CAR from FSP-T to FSP-M is an ugly hack where I only convinced 90% (with my approach 😊) but ended up in adding that logic as we covered all corner cases. Here is

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-25 Thread cbduggap
Thanks, Nate, for taking some time to review the patch. I agree that GlobalDatapointer usage to pass Top of CAR from FSP-T to FSP-M is an ugly hack where I only convinced 90% (with my approach 😊) but ended up in adding that logic as we covered all corner cases. Here is the background why: 1.

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-23 Thread Nate DeSimone
Hi Chinni, Using the FspGlobalDataPointer as a scratchpad for your top of CAR early and then putting the real global data into it later is an ugly hack. If you are going to initialize the FspGlobalDataPointer in FSP-T, then FSP-T needs to actually initialize that FSP global data structure fully

[edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-15 Thread cbduggap
Changes to support spec changes 1. Remove usage of Pcd. 2. Change code to validate the Temporary Ram size input. 3. Consume the input saved in YMM Register Cc: Sai Chaganty Cc: Nate DeSimone Cc: Chiu Chasel Cc: Duggapu Chinni B Signed-off-by: Duggapu Chinni B --- IntelFsp2Pkg/FspSecCore/F