Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-19 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/cf8a716 -Original Message- From: Huang, Yanbo Sent: Tuesday, September 5, 2023 7:19 PM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2] IpmiFeaturePkg: Refine cod

Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-19 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Huang, Yanbo Sent: Tuesday, September 5, 2023 7:19 PM To: devel@edk2.groups.io Cc: Huang, Yanbo ; Isaac Oram ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report REF:https://

Re: [edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-10 Thread Huang, Yanbo
] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) == 1) {" will not be executed in current code, put it within "case SysInterfaceKcs:" to avoid this issue. Cc:

[edk2-devel] [PATCH v2] IpmiFeaturePkg: Refine code to avoid warning report

2023-09-05 Thread Huang, Yanbo
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4522 "if (FixedPcdGet8 (PcdKcsInterfaceSupport) == 1) {" will not be executed in current code, put it within "case SysInterfaceKcs:" to avoid this issue. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Yanbo Huang --- .../Ip