Re: [edk2-devel] [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4'

2019-10-31 Thread Dandan Bi
> -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, October 30, 2019 9:46 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Dong, Eric > Subject: [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private- > >Attribute >> 4' > > The size of mHiiEfiColors is 16. >

[edk2-devel] [PATCH v2] MdeModulePkg/HiiDatabaseDxe: Add check for 'Private->Attribute >> 4'

2019-10-30 Thread Zhang, Shenglei
The size of mHiiEfiColors is 16. mHiiEfiColors[Private->Attribute >> 4] may be out of boundary. So add a check for that. Cc: Dandan Bi Cc: Eric Dong Signed-off-by: Shenglei Zhang --- v2: Instead of returing value, we add ASSERT to ensure "Private->Attribute >> 4" is not out of boundary.