Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

[AMD Official Use Only - AMD Internal Distribution Only] Hi Ray, You are right. The change is NOT necessary. Thanks feng From: Ni, Ray Sent: Tuesday, May 7, 2024 8:26 PM To: Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: Ding, Feng (Sunnyvale) ; He, Jiangang ; Chang, Abner

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

Thanks for confirming. Thanks, Ray From: Ding, Feng (Sunnyvale) Sent: Friday, May 17, 2024 8:39 To: Ni, Ray ; Hsueh, Hong-Chih (Neo) ; Laszlo Ersek ; devel@edk2.groups.io Cc: He, Jiangang ; Chang, Abner ; gaolim...@byosoft.com.cn Subject: RE: [PATCH v2] MdeMo

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

Neo, I don't think your change is needed because of the following existing logic where RemoveAllPciDeviceOnBridge() is called to destroy/free all PCI nodes. if (Operation == EfiPciHotplugRequestRemove) { if (*NumberOfChildren == 0) { // // Remove all devices on the bridge

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

[AMD Official Use Only - General] Hi @ray...@intel.com, Sorry you bother you, may I have your feedback for this patch? If it looks good to you could you help to give me an R-b ? Thank you. Regards, Neo From: Laszlo Ersek Sent: Sunday,

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The actions > require PciHotPlugRequestNotify to add a root bridge or remove a root bridge > completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return with > no-action on

[edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The actions require PciHotPlugRequestNotify to add a root bridge or remove a root bridge completely. In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return with no-action on second plug because bridge tree shows config