Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-22 Thread joeyli via groups.io
---Original Message- > > From: joeyli > > Sent: Tuesday, December 20, 2022 3:10 PM > > To: devel@edk2.groups.io; Yao, Jiewen > > Cc: Lee, Chun-Yi ; Xu, Min M > > ; Gerd Hoffmann ; Tom > > Lendacky ; James Bottomley > > ; Aktas, Erdem > &

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-21 Thread Yao, Jiewen
s Bottomley > ; Aktas, Erdem > Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity > checking failed of NvVarStore in some cases > > Hi Jiewen, > > Sorry for I didn't create tiano CI on github in time. And thanks for your > help to merge my patch. &

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread joeyli via groups.io
Hi Jiewen, Sorry for I didn't create tiano CI on github in time. And thanks for your help to merge my patch. I will create tiano CI in next time after getting our Review-by tag. Thanks! Joey Lee On Sat, Dec 17, 2022 at 03:17:42AM +, Yao, Jiewen via groups.io wrote: > Thanks for the fix. >

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread Yao, Jiewen
n > ; Tom Lendacky ; James > Bottomley ; Aktas, Erdem ; > Lee, Chun-Yi > Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity > checking failed of NvVarStore in some cases > > Thanks for the fix. > Reviewed-by: Jiewen Yao > > Question:

[edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-19 Thread Lee, Chun-Yi
In the commit 4f173db8b4 "OvmfPkg/PlatformInitLib: Add functions for EmuVariableNvStore", it introduced a PlatformValidateNvVarStore() function for checking the integrity of NvVarStore. In some cases when the VariableHeader->StartId is VARIABLE_DATA, the VariableHeader->State is not just one of

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: Fix integrity checking failed of NvVarStore in some cases

2022-12-16 Thread Yao, Jiewen
Thanks for the fix. Reviewed-by: Jiewen Yao Question: Have you run tiano CI by yourself, before submit the patch? > -Original Message- > From: Lee, Chun-Yi > Sent: Thursday, December 15, 2022 10:27 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Gerd Hoffmann > ; Yao, Jiewen ; Tom