Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-04 Thread Sami Mujawar
Hi Abdul, Thanks for confirming. I think the matrix at https://github.com/tianocore/edk2/tree/master/.pytool needs updating. Can you send a patch to update that, please? Regards, Sami Mujawar On 04/01/2024, 04:05, "Attar, AbdulLateef (Abdul Lateef)" mailto:abdullateef.at...@amd.com>>

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
Hi Sami Mujawar,     Looks like current edk2 CI handles the X64, IA32 for both GCC and VS2019 to build DynamicTablesPkg. I can see that TARGET_FMP_FAT_TEST is failed for VS2019 for below PR(which is expected). https://github.com/tianocore/edk2/pull/5215 Thanks AbduL On 04-01-2024

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
Hi Sami Mujawar,     Thanks for quick response, update and merge of the patch. Yes, I build DynamicTablesPkg for IA32 and X64 using VS2019(tool-chain VS2019) and also using GCC 11.4 (tool-chain GCC). I'll take a look at edk2 CI. Thanks AbduL I'll take a look at edk2 CI and On 03-01-2024

Re: [edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Sami Mujawar
Hi Abdul, I have merged this series as d7d4f09ff815..2576cbafec98. Now that support for X64 and IA32 is enabled in DynamicTablesPkg, it would be good to enable that in the edk2 CI. That way we do not accidently break the builds. To enable edk2 CI for AARCH64 using GCC, I had made the change at

[edk2-devel] [PATCH v2 0/2] DynamicTablesPkg: Fix IA32 and X64 compilation errors

2024-01-03 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar PR: https://github.com/tianocore/edk2/pull/5209 v2: Fix the IA32 compilation errors. v1: Fix the X64 compilation errors. Cc: Pierre Gondois pierre.gond...@arm.com Cc: Sami Mujawar sami.muja...@arm.com Cc: Abdul Lateef Attar Abdul Lateef Attar (2): DynamicTablesPkg: