Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-14 Thread Wang, Jian J
Jiewen, See my comments below. > -Original Message- > From: Yao, Jiewen > Sent: Friday, June 14, 2019 6:41 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: RE: [PATCH v2 0/3] Common OBB verification feature > > Thanks.

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-14 Thread Yao, Jiewen
Thanks. Comment below: > -Original Message- > From: Wang, Jian J > Sent: Friday, June 14, 2019 8:30 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: RE: [PATCH v2 0/3] Common OBB verification feature > > Jiewen, > > > -

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-13 Thread Wang, Jian J
8:30 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature > > Jiewen, > > > -Original Message- > > From: Yao, Jiewen > > S

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-13 Thread Wang, Jian J
Jiewen, > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, June 12, 2019 12:49 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Hernandez Beltran, Jorge > ; Han, Harry > Subject: RE: [PATCH v2 0/3] Common OBB verification feature > > Thanks Jian. Some comment b

Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-11 Thread Yao, Jiewen
Thanks Jian. Some comment below: 0) Please add what unit test has been done. 1) Can we use UINT64 for Base and Length? typedef struct _HASHED_FV_INFO { UINT32 Base; UINT32 Length; UINT64 Flag; } HASHED_FV_INFO; 2) Can we remove the hard co

[edk2-devel] [PATCH v2 0/3] Common OBB verification feature

2019-06-10 Thread Wang, Jian J
>V2: fix parameter description error found by ECC https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang Cc: Jiewen Yao Cc: "Hernandez Beltran, Jorge" Cc: Harry Han Jian J Wang (3): SecurityPkg: add definitions for OBB verification SecurityPkg/FvReportPei: implement a common