Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-09 Thread Chao Li
v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Hi Ray, I'm willing change it to a PEIM if it doesn't fit as a library. I think if it is a PEIM, we need a new GUID to sotre the memory map resouce, or use an already defined GUID. I will put it under the UefiCpuPkg, called

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Ni, Ray
; Sunil V L ; Bibo Mao ; Dongyan Qian Subject: Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg Hi Ray, I'm willing change it to a PEIM if it doesn't fit as a library. I think if it is a PEIM, we need a new GUID to sotre the memory map resouce, or use

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Chao Li
Hi Ray, I'm willing change it to a PEIM if it doesn't fit as a library. I think if it is a PEIM, we need a new GUID to sotre the memory map resouce, or use an already defined GUID. I will put it under the UefiCpuPkg, called CpuMmuInitPei, folder: UefiCpuPkg/CpuMmuInitPei/LoongArch64/. May

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-08 Thread Ni, Ray
Chao, Sorry I missed your mail. If ConfigureMemoryManagementUnit() is called in PEI, can you move the logic to a LoongArch specific PEIM? My concern is we may need more review on the lib API ConfigureMemoryManagementUnit() if we position it as a library. If we move the logic in a PEIM and the

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-04-02 Thread Chao Li
Hi Ray, I'd love to hear back from you, and ask for any more suggestions. Thank you ! Thanks, Chao On 2024/3/29 09:28, Chao Li wrote: Hi Ray, I guess you are very busy recently. If you see this mail, please reply to me, can I can still use the low-high level libraries solution in next

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-28 Thread Chao Li
Hi Ray, I guess you are very busy recently. If you see this mail, please reply to me, can I can still use the low-high level libraries solution in next commit? Thanks, Chao On 2024/3/26 09:32, Chao Li wrote: Hi Ray, I responded your comments yesterday, it looks like we have different

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-25 Thread Chao Li
Hi Ray, I responded your comments yesterday, it looks like we have different opinions on patches 10 and 11, the rest looks fine. Could you please consider patches 10 and 11? I think this way is probably the best solution. I hope this series to be merged as soon as passable, because the next

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-24 Thread Chao Li
Hi Ray, Thank you for reviewing my patch series very carefully. Here are my comments: Thanks, Chao On 2024/3/25 10:46, Ni, Ray wrote: Chao, Thank you for your patience for preparing the new version of patches. However, I still have following minor comments: For patches 1~6: Reviewed-by: Ray

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-24 Thread Ni, Ray
Chao, Thank you for your patience for preparing the new version of patches. However, I still have following minor comments: For patches 1~6: Reviewed-by: Ray Ni For patches 7: can you define meaning of bits in the Attributes/Mask? It seems you are reusing the definitions defined for 7.2.3

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-22 Thread Gerd Hoffmann
On Wed, Mar 20, 2024 at 04:41:52PM +0800, Chao Li wrote: > This patch set adjusted some order in UefiCpuPig alphabetically, added > LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of > the first patch series v8 submitted at > https://edk2.groups.io/g/devel/message/114526. >

Re: [edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-21 Thread Chao Li
Hi Ray and other maintainers, I submitted this series few days ago, could you review them and give me the R-B? Thanks, Chao On 2024/3/20 16:41, Chao Li wrote: This patch set adjusted some order in UefiCpuPig alphabetically, added LoongArch libraries and drivers into UefiCpuPkg, it is a

[edk2-devel] [PATCH v2 00/13] Part 2 patch set to add LoongArch support into UefiCpuPkg

2024-03-20 Thread Chao Li
This patch set adjusted some order in UefiCpuPig alphabetically, added LoongArch libraries and drivers into UefiCpuPkg, it is a continuation of the first patch series v8 submitted at https://edk2.groups.io/g/devel/message/114526. And also separated from