Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-02 Thread Pedro Falcato
Hi Liming, I've just sent out the v3. Thanks, Pedro On Thu, Nov 3, 2022 at 1:01 AM gaoliming wrote: > Pedro: > > Marvin gave one suggestion for the code change ( > https://edk2.groups.io/g/devel/message/95635). Can you response it? > > > > Thanks > > Liming > > *发件人:* Pedro Falcato >

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-11-02 Thread Pedro Falcato
Can someone push this? Is there a blocker here? On Wed, Oct 26, 2022 at 4:54 PM Kinney, Michael D < michael.d.kin...@intel.com> wrote: > Acked-by: Michael D Kinney > > > > -Original Message- > > From: Yao, Jiewen > > Sent: Wednesday, October 26, 2022 6:35 AM > > To: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-10-27 Thread Marvin Häuser
Comment inline. > On 26. Oct 2022, at 15:35, Yao, Jiewen wrote: > > That is good catch. > > Reviewed-by: Jiewen Yao > > >> -Original Message- >> From: Kinney, Michael D >> Sent: Wednesday, October 26, 2022 12:23 AM >> To: Pedro Falcato ; devel@edk2.groups.io >> Cc: Vitaly Cheptsov

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-10-26 Thread Michael D Kinney
Acked-by: Michael D Kinney > -Original Message- > From: Yao, Jiewen > Sent: Wednesday, October 26, 2022 6:35 AM > To: Kinney, Michael D ; Pedro Falcato > ; devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Marvin Häuser > ; Gao, Liming ; Liu, > Zhiguang > Subject: RE: [PATCH v2 1/1]

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-10-26 Thread Yao, Jiewen
That is good catch. Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, October 26, 2022 12:23 AM > To: Pedro Falcato ; devel@edk2.groups.io > Cc: Vitaly Cheptsov ; Marvin Häuser > ; Gao, Liming ; Liu, > Zhiguang ; Yao, Jiewen > Subject: RE:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-10-25 Thread Michael D Kinney
Adding Jiewen Yao. Mike > -Original Message- > From: Pedro Falcato > Sent: Monday, October 24, 2022 3:43 PM > To: devel@edk2.groups.io > Cc: Pedro Falcato ; Vitaly Cheptsov > ; Marvin Häuser ; > Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang > Subject: [PATCH v2 1/1]

[edk2-devel] [PATCH v2 1/1] MdePkg/BaseLib: Fix out-of-bounds reads in SafeString

2022-10-24 Thread Pedro Falcato
OpenCore folks established an ASAN-equipped project to fuzz Ext4Dxe, which was able to catch these (mostly harmless) issues. Signed-off-by: Pedro Falcato Cc: Vitaly Cheptsov Cc: Marvin Häuser Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Library/BaseLib/SafeString.c | 24