[edk2-devel] [PATCH v2 1/1] ShellPkg: Tidy for code readability

2023-11-29 Thread Daniel Nguyen
Use error handling instead of success handling. Less indented logic is easier to read. Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Daniel Nguyen --- ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c | 41 +++- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/She

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: Tidy for code readability

2023-12-13 Thread Tom Pilar
Hi Zhichao & Ray, Can you have a quick review of this patch, no logic has changed, just a code tidy. Cheers, Tom > On 29 Nov 2023, at 18:28, Daniel Nguyen via groups.io > wrote: > > Warning: EXTERNAL SENDER, use caution when opening links or attachments. > > > Use error handling instead of

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: Tidy for code readability

2023-12-13 Thread Gao, Zhichao
The patch looks good to me. Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Tom Pilar > Sent: Wednesday, December 13, 2023 7:45 PM > To: devel@edk2.groups.io; Daniel Nguyen > Cc: nd ; Gao, Zhichao ; Ni, Ray > > Subject: Re: [edk2-devel] [P